I feel this way about open source and the seemingly frequent lack of detailed code reviews. This one project had two function options to use from a library. One handles errors by returning them to the caller so they can be handled gracefully. The other, calls PANIC! They chose the latter and it causes a crash loop for a relatively easy to hit code condition that is sensitive to User input.
Why ask for unit test, in the code review, when you can just accept the contribution for a feature that is used in large corps.
I will say I hate having to pester folks to do review on a merge. The place im currently at requires two and its pulling teeth to get folks to look at someone elses code. well except for me I always treat merges as priority as that is ready to go whereas with mine if I have not merged then its not that ready.
I hate places without code review. Makes me nervous as heaven to merge code and want as many double checks as possible.
I feel this way about open source and the seemingly frequent lack of detailed code reviews. This one project had two function options to use from a library. One handles errors by returning them to the caller so they can be handled gracefully. The other, calls PANIC! They chose the latter and it causes a crash loop for a relatively easy to hit code condition that is sensitive to User input.
Why ask for unit test, in the code review, when you can just accept the contribution for a feature that is used in large corps.
I will say I hate having to pester folks to do review on a merge. The place im currently at requires two and its pulling teeth to get folks to look at someone elses code. well except for me I always treat merges as priority as that is ready to go whereas with mine if I have not merged then its not that ready.